691758 - [Tablet] Optgroup should not have checkbox in select popup helper

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Martijn Wargers (dead)]

See testcase https://bugzilla.mozilla.org/attachment.cgi?id=562610
which is from bug 689403.
The second line in the select list is an optgroup element, which can't be selected. The select helper popup shows a checkmark after it, which gives the wrong impression that you are able to select it.

Comment 1

[Martijn Wargers (dead)]

Attachment: testcase

Also, no checkmarks should be there for disabled options.

Comment 2

[Martijn Wargers (dead)]

The checkmark that I see is from here:
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/gingerbread/images/radio-selected-hdpi.png
Weird that it comes from the gingerbread theme.
I'm testing on the EEE Transformer, so I would expect the honeycomb theme.

Comment 3

[Martijn Wargers (dead)]

Attachment: testcase2

Comment 4

[Martijn Wargers (dead)]

Attachment: testcase3

Comment 5

[Martijn Wargers (dead)]

Attachment: patch

This fixes it for me. Note in the patch that I omitted the ':not([disabled="true"])' part of the rule for the .selected case, because disabled options can be selected, only not by user input.

I can write a browser-chrome test for this, but I first would like to have the browser-chrome test in bug 685197 checked in, before I give it a try.

Comment 6

[Wesley Johnston (:wesj)]

Comment on attachment 564882 [details] [diff] [review]
patch

Review of attachment 564882 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks Martijn!

Comment 7

[Martijn Wargers (dead)]

Attachment: mq diff

Comment 8

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/ff2e14cc772f

Comment 9

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/ff2e14cc772f

Comment 10

[Aaron Train [:aaronmt]]

Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)