Closed
Bug 691758
Opened 14 years ago
Closed 13 years ago
[Tablet] Optgroup should not have checkbox in select popup helper
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Firefox 10
People
(Reporter: martijn.martijn, Assigned: martijn.martijn)
References
()
Details
(Keywords: testcase)
Attachments
(4 files, 1 obsolete file)
See testcase https://bugzilla.mozilla.org/attachment.cgi?id=562610
which is from bug 689403.
The second line in the select list is an optgroup element, which can't be selected. The select helper popup shows a checkmark after it, which gives the wrong impression that you are able to select it.
|
Assignee | |
Comment 1•14 years ago
|
||
Also, no checkmarks should be there for disabled options.
|
||
Updated•14 years ago
|
Assignee: nobody → wjohnston
|
|
Assignee | |
Comment 2•14 years ago
|
||
The checkmark that I see is from here:
http://mxr.mozilla.org/mozilla-central/source/mobile/themes/core/gingerbread/images/radio-selected-hdpi.png
Weird that it comes from the gingerbread theme.
I'm testing on the EEE Transformer, so I would expect the honeycomb theme.
|
|
Assignee | |
Comment 3•14 years ago
|
||
|
|
Assignee | |
Comment 4•14 years ago
|
||
|
|
Assignee | |
Comment 5•14 years ago
|
||
This fixes it for me. Note in the patch that I omitted the ':not([disabled="true"])' part of the rule for the .selected case, because disabled options can be selected, only not by user input.
I can write a browser-chrome test for this, but I first would like to have the browser-chrome test in bug 685197 checked in, before I give it a try.
Attachment #564882 -
Flags: review?(wjohnston)
|
||
Comment 6•14 years ago
|
||
Comment on attachment 564882 [details] [diff] [review]
patch
Review of attachment 564882 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me. Thanks Martijn!
Attachment #564882 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Comment 7•14 years ago
|
||
Attachment #564882 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Assignee: wjohnston → martijn.martijn
Keywords: checkin-needed
|
||
Comment 8•14 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
OS: Windows 7 → Android
Hardware: x86 → All
Target Milestone: --- → Firefox 10
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 10•13 years ago
|
||
Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111011 Firefox/10.0a1 Fennec/10.0a1
Samsung Galaxy SII (2.3.4)
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•